Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Remove configure.bat (#83)" #84

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Revert "Remove configure.bat (#83)" #84

merged 1 commit into from
Apr 15, 2022

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Reverts #83 to fix gazebo11 CI (a repeat of #66 and #76)

Summary

Removing configure.bat breaks gazebo11 CI:

Build Status https://build.osrfoundation.org/job/gazebo-ci-gazebo11-windows7-amd64/140/

This reverts commit 73acac7.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters
Revert "Remove configure.bat (#83)"
4d2f47c 
This reverts commit 73acac7.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from chapulina April 15, 2022 00:37
@scpeters scpeters requested a review from caguero as a code owner April 15, 2022 00:37
@github-actions github-actions bot added 🌱 garden Ignition Garden 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Apr 15, 2022
@scpeters scpeters mentioned this pull request Apr 15, 2022
Merged
7 tasks
chapulina
chapulina approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks for catching this

@chapulina
Copy link
Contributor

Possible fix for the Windows build: gazebo-tooling/release-tools#706

@scpeters
Copy link
Member Author

merging to fix gazebo11; will follow up with windows build fix later

@scpeters scpeters merged commit 1436de9 into ign-tools1 Apr 15, 2022
@scpeters scpeters deleted the restore_configure_bat branch April 15, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress 🌱 garden Ignition Garden
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scpeters @chapulina